Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added known limitation section to the docs #796

Merged
merged 5 commits into from
Jul 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/796.doc.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added known limitations section to documentation.
07pepa marked this conversation as resolved.
Show resolved Hide resolved
1 change: 1 addition & 0 deletions docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,5 @@ Features
crash
how-to
how-it-works
known-limitations
changelog
07pepa marked this conversation as resolved.
Show resolved Hide resolved
07pepa marked this conversation as resolved.
Show resolved Hide resolved
52 changes: 52 additions & 0 deletions docs/known-limitations.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
Known limitations
=================

pytest-xdist has some limitations that may be supported in pytest but can't be supported in pytest-xdist.

Order and amount of test must be consistent
-------------------------------------------

Is is not possible to have tests that differ in order or their amount across workers.

This is especially true with ``pytest.mark.parametrize``, when values are produced with sets or other unordered iterables/generators.


Example:

.. code-block:: python

import pytest

@pytest.mark.parametrize("param", {"a","b"})
def test_pytest_parametrize_unordered(param):
pass

In the example above, the fact that ``set`` are not necessarily ordered can cause different workers
to collect tests in different order, which will throw an error.

Workarounds
~~~~~~~~~~~

A solution to this is to guarantee that the parametrized values have the same order.

Some solutions:

* Convert your sequence to a ``list``.

.. code-block:: python

import pytest

@pytest.mark.parametrize("param", ["a", "b"])
def test_pytest_parametrize_unordered(param):
pass

* Sort your sequence, guaranteeing order.

.. code-block:: python

import pytest

@pytest.mark.parametrize("param", sorted({"a", "b"}))
def test_pytest_parametrize_unordered(param):
pass
3 changes: 2 additions & 1 deletion src/xdist/report.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ def report_collection_diff(from_collection, to_collection, from_id, to_id):
error_message = (
"Different tests were collected between {from_id} and {to_id}. "
"The difference is:\n"
"{diff}"
"{diff}\n"
"To see why this happens see Known limitations in documentation"
).format(from_id=from_id, to_id=to_id, diff="\n".join(diff))
msg = "\n".join(x.rstrip() for x in error_message.split("\n"))
return msg
3 changes: 2 additions & 1 deletion testing/test_dsession.py
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,8 @@ def test_report_collection_diff_different() -> None:
" bbb\n"
"+XXX\n"
" ccc\n"
"-YYY"
"-YYY\n"
"To see why this happens see Known limitations in documentation"
)

msg = report_collection_diff(from_collection, to_collection, "1", "2")
Expand Down