-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix service.exists #767
Fix service.exists #767
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
I wonder what the ^
is for. Isn't it redundant?
The I only corrected the missing space between |
Ah, I always get confused by the % substitution :)
Of course, I was just curious. |
62abe2e
to
85f027b
Compare
I think this is to match service with or without the ".service" suffix. Maybe we could think about a better way of doing this because service |
Merged, thanks! |
This can be done now that pytest-dev/pytest-testinfra#767 has been merged and released in version 10.1.1: https://github.com/pytest-dev/pytest-testinfra/releases/tag/10.1.1 See also: - pytest-dev/pytest-testinfra#757 - pytest-dev/pytest-testinfra#767
This can be done now that pytest-dev/pytest-testinfra#767 has been merged and released in version 10.1.1: https://github.com/pytest-dev/pytest-testinfra/releases/tag/10.1.1 See also: - pytest-dev/pytest-testinfra#757 - pytest-dev/pytest-testinfra#767
This can be done now that pytest-dev/pytest-testinfra#767 has been merged and released in version 10.1.1: https://github.com/pytest-dev/pytest-testinfra/releases/tag/10.1.1 See also: - pytest-dev/pytest-testinfra#757 - pytest-dev/pytest-testinfra#767
service.exists fail with systemd because there was a typo in the underlying command, missing a space between grep option
-q
and service name.This PR fixes that problem
This fixes #768