New ansible runner #432
Merged
New ansible runner #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philpep
force-pushed
the
ansible-fixes
branch
2 times, most recently
from
829ef5e
to
d7f99b0
Compare
jctanner
reviewed
Apr 30, 2019
|
|
||
| def run_module(self, host, module_name, module_args, become=False, | ||
| check=True, **kwargs): | ||
| cmd, args = 'ansible --tree %s', [None] |
There was a problem hiding this comment.
I had no idea this existed. Pretty neat!
|
Sorry, kinda out of the loop but what is the relation of this PR with #410? In the case of manual testing this new runner with testinfra under molecule, I should be aiming to try this PR branch? Thanks for the good work! |
Use a custom inventory so the test does not depend on "host" fixture and run faster. Also use AnsibleRunner instead of AnsibleBackend.
This will be used in next commit.
Following specification on #431 * Use ansible-inventory cli to parse inventory, group and host variables * Ansible backend re-use existing backend (local, ssh) to run commands. This is a breaking change because we do not support all connection backends from ansible. * The Ansible module run with the ansible cli. * Add more tests * Fix the skipped "encoding" test which pass now. This fix maintainability issue with ansible and the license issue (ansible is GPL). Closes #431
Group can be nested with the ":children" notation. https://docs.ansible.com/ansible/latest/user_guide/intro_inventory.html#groups-of-groups-and-group-variables Also handle "all" like a normal group since "ansible-inventory" output all groups (including "ungrouped") to be a children of "all".
|
I merge this PR. I think it's a good enough base to work with. It should be fully backward compatible, enough performant and fixes all the issues from #431 . It think we will probably have small regressions , I bet around sudo or with some complex usages in test suites, so this will go in a major release 3.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for #431