Log in subtests similar to stdout #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
requested changes
May 13, 2023
There was a problem hiding this comment.
Thanks a lot @rhoban13, this looks excellent!
Besides my comments, could you please update the CHANGELOG? Thanks!
I will be happy to make a new release once this is merged. 👍
Co-authored-by: Bruno Oliveira <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
rhoban13
commented
May 13, 2023
| @@ -176,14 +177,27 @@ def _capturing_output(self): | |||
| fixture.close() | |||
| captured.out = out | |||
| captured.err = err | |||
|
|
|||
| @contextmanager | |||
There was a problem hiding this comment.
Noticing the comment on line 154 above "# capsys or capfd are active, subtest should not capture". Do I need to do anything similar if the caplog fixture is active?
There was a problem hiding this comment.
I don't think so, the logging capture supports multiple logs being captured at the same time, which is not true for capsys/capfd. 👍
rhoban13
force-pushed
the
logging_in_subtests
branch
from
5524165 to
4f39650
Compare
rhoban13
force-pushed
the
logging_in_subtests
branch
from
4f39650 to
9430a59
Compare
nicoddemus
approved these changes
May 15, 2023
|
Thanks @rhoban13! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging inside subtests is not displayed unless the parent test fails. This PR proposes capturing logging for each subtest similar to how stdout/stderr is currently captured and displaying with similar granularity.
fixes #87