Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_requires: do not allow pytest 4.2.0 #697

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Feb 1, 2019

@blueyed blueyed merged commit b6bafc4 into pytest-dev:master Feb 1, 2019
@blueyed blueyed deleted the pin branch February 1, 2019 12:07
@codecov-io
Copy link

Codecov Report

Merging #697 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #697   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files          33       33           
  Lines        1869     1869           
  Branches      159      159           
=======================================
  Hits         1768     1768           
  Misses         77       77           
  Partials       24       24
Flag Coverage Δ
#dj110 86.57% <ø> (ø) ⬆️
#dj111 88.92% <ø> (ø) ⬆️
#dj18 87.53% <ø> (ø) ⬆️
#dj19 86.35% <ø> (ø) ⬆️
#dj20 86.83% <ø> (ø) ⬆️
#dj21 82.93% <ø> (ø) ⬆️
#dj22 82.93% <ø> (ø) ⬆️
#djmaster 82.93% <ø> (ø) ⬆️
#mysql_innodb 87.05% <ø> (ø) ⬆️
#mysql_myisam 86.89% <ø> (ø) ⬆️
#postgres 90.15% <ø> (ø) ⬆️
#py27 91.81% <ø> (ø) ⬆️
#py34 86.35% <ø> (ø) ⬆️
#py35 86.57% <ø> (ø) ⬆️
#py36 87.74% <ø> (ø) ⬆️
#py37 83.3% <ø> (ø) ⬆️
#sqlite 88.87% <ø> (ø) ⬆️
#sqlite_file 86.35% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe6ddb8...65bc950. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Feb 1, 2019

Codecov Report

Merging #697 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #697   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files          33       33           
  Lines        1869     1869           
  Branches      159      159           
=======================================
  Hits         1768     1768           
  Misses         77       77           
  Partials       24       24
Flag Coverage Δ
#dj110 86.57% <ø> (ø) ⬆️
#dj111 88.92% <ø> (ø) ⬆️
#dj18 87.53% <ø> (ø) ⬆️
#dj19 86.35% <ø> (ø) ⬆️
#dj20 86.83% <ø> (ø) ⬆️
#dj21 82.93% <ø> (ø) ⬆️
#dj22 82.93% <ø> (ø) ⬆️
#djmaster 82.93% <ø> (ø) ⬆️
#mysql_innodb 87.05% <ø> (ø) ⬆️
#mysql_myisam 86.89% <ø> (ø) ⬆️
#postgres 90.15% <ø> (ø) ⬆️
#py27 91.81% <ø> (ø) ⬆️
#py34 86.35% <ø> (ø) ⬆️
#py35 86.57% <ø> (ø) ⬆️
#py36 87.74% <ø> (ø) ⬆️
#py37 83.3% <ø> (ø) ⬆️
#sqlite 88.87% <ø> (ø) ⬆️
#sqlite_file 86.35% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe6ddb8...65bc950. Read the comment docs.

@nicoddemus
Copy link
Member

nicoddemus commented Feb 1, 2019

This probably should be mentioned in the CHANGELOG right?

Nevermind, just saw it is there already. 👍

@nicoddemus
Copy link
Member

Hmm on second thought it would probably be nice to mention that there's an incompatibility that's being work out.

@blueyed
Copy link
Contributor Author

blueyed commented Feb 1, 2019

@nicoddemus
Yes, it might make sense to mention that it is a known issue, and not pinned just-because.

But it should also have been pinned to <4.2 - I've done it a bit hastly due to having no time after all, but considered it to be rather critical.

@nicoddemus
Copy link
Member

Sure thing, no worries, appreciate taking the time to do it even if you don't have it. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants