docs: add warning about sqlite specific snippet + fix typos #666
Conversation
docs/database.rst
Outdated
| @@ -419,8 +419,8 @@ Create the test database from a custom SQL script | |||
|
|
|||
| You can replace the :fixture:`django_db_setup` fixture and run any code in its | |||
| place. This includes creating your database by hand by running a SQL script | |||
| directly. This example shows how sqlite3's executescript method. In more a more | |||
| general use cases you probably want to load the SQL statements from a file or | |||
| directly. This example shows how sqlite3's executescript method. In a more | |||
There was a problem hiding this comment.
This example shows how sqlite3's executescript method.
Missing a verb?
There was a problem hiding this comment.
Oh, nice catch. I believe that "how" is extra actually. Should I amend previous commit with the removal of it? @blueyed
There was a problem hiding this comment.
Yes, please do.. - but a new commit is fine, too - will squash-merge it then.
Consider using [ci skip] in the message.
checkqa job currently fails due to newer flake8 it seems, so just ignore it.
Thanks!
There was a problem hiding this comment.
I've amended the commit and added [ci skip]. Thanks to you guys for the project, keep up the good work, glad I could help somehow 😄
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
==========================================
- Coverage 94.38% 86.69% -7.69%
==========================================
Files 33 33
Lines 1834 1834
Branches 156 155 -1
==========================================
- Hits 1731 1590 -141
- Misses 78 195 +117
- Partials 25 49 +24
Continue to review full report at Codecov.
|
|
Thanks! |
I stumbled upon this snippet in docs but I'm using Postgres, so
executescriptis not available inpsycopg, I quickly found that it was supposed to beexecuteonly, however, I still think it's valuable to have this warning for whoever comes across this.Took the time to also fix a few minor typos.