Add testcase to show erroneous multiple runs of django.setup() #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased against master. |
|
Will include this into #629. |
blueyed
added a commit
to blueyed/pytest-django
that referenced
this pull request
Jul 26, 2018
…pytest_configure Basically the test from pytest-dev#538.
|
I think the test added to https://github.com/pytest-dev/pytest-django/pull/629/files#diff-b8f370066f4a8dcc417f6e09e1689a84 is enough to test this, do you agree? |
blueyed
added a commit
to blueyed/pytest-django
that referenced
this pull request
Jul 26, 2018
…pytest_configure Basically the test from pytest-dev#538.
|
Backed out the changes in #629, basically only fixing this issue now. |
|
Yes the test added above seems to make the same as mine, ensuring django.setup() is only called once |
|
Cool, merged #629. |
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testcase to advance on #531