Avoid mutable global state in SettingsWrapper

pytest-dev · Nov 10, 2023 · 12cf877 · 12cf877
1 parent baaafd8
commit 12cf877
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pytest_django/fixtures.py b/pytest_django/fixtures.py
@@ -8,7 +8,6 @@
     TYPE_CHECKING,
     Any,
     Callable,
-    ClassVar,
     ContextManager,
     Generator,
     Iterable,
@@ -498,7 +497,9 @@ def async_rf() -> django.test.AsyncRequestFactory:
 
 
 class SettingsWrapper:
-    _to_restore: ClassVar[list[Any]] = []
+    def __init__(self) -> None:
+        self._to_restore: list[django.test.override_settings]
+        object.__setattr__(self, "_to_restore", [])
 
     def __delattr__(self, attr: str) -> None:
         from django.test import override_settings