Fix: Avoid warning on latest Pytest versions #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytest added a deprecation warning to signal fixtures being called directly as functions. Ref: pytest-dev/pytest#3661 Ref: https://docs.pytest.org/en/latest/deprecations.html#calling-fixtures-directly
nicoddemus
reviewed
Sep 27, 2018
tox.ini
Outdated
| @@ -4,7 +4,7 @@ minversion = 2.5.0 | |||
|
|
|||
| [testenv] | |||
| extras = testing | |||
| commands = coverage run -m pytest {posargs} | |||
| commands = coverage run -m pytest -W error {posargs} | |||
There was a problem hiding this comment.
Probably better to add this to pytest.ini instead:
[pytest]
filterwarnings = errorThere was a problem hiding this comment.
Good point, there is some config in setup.cfg already, I've moved it there.
|
Anything blocking this from merging? Would be really nice to get this released! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pytest added a deprecation warning to signal fixtures being called
directly as functions.
Ref: pytest-dev/pytest#3661
Ref: https://docs.pytest.org/en/latest/deprecations.html#calling-fixtures-directly