Event loop scoping via scope kwarg to asyncio mark #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seifertm
changed the title
seifertm
force-pushed
the
asyncio-mark-scope-kwarg
branch
from
3f09fa6
to
bfb10a0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
==========================================
+ Coverage 94.31% 94.72% +0.41%
==========================================
Files 2 2
Lines 422 455 +33
Branches 89 92 +3
==========================================
+ Hits 398 431 +33
- Misses 14 15 +1
+ Partials 10 9 -1
☔ View full report in Codecov by Sentry. |
seifertm
force-pushed
the
asyncio-mark-scope-kwarg
branch
from
bfb10a0
to
17790f9
Compare
…e" kwarg to the asyncio mark. Signed-off-by: Michael Seifert <[email protected]>
Signed-off-by: Michael Seifert <[email protected]>
Signed-off-by: Michael Seifert <[email protected]>
Signed-off-by: Michael Seifert <[email protected]>
seifertm
force-pushed
the
asyncio-mark-scope-kwarg
branch
from
17790f9
to
dead6b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the asyncio_event_loop mark introduced in pytest-asyncio v0.22.0. The approach is incapable of handling package and session scoped loops, which turned out to be a popular use case.
This changeset introduces an optional scope keyword argument to the existing asyncio mark as a replacement.
Resolves #657