Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permission handling for opening file via file descriptor #983

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

mrbean-bremen
Copy link
Member

@mrbean-bremen mrbean-bremen commented Mar 16, 2024

This fixes at least some of the issues with permission handling if opening files via the file descriptor.
I'm sure there are more problems, as the description of the behavior in the Python documentation is not sufficient and you have to fall back to OS-specific documentation. Also, there are differences in the behavior between CPython and PyPy.

Tasks

  • Unit tests added that reproduce the issue or prove feature is working
  • Fix or feature added
  • Entry to release notes added
  • Pre-commit CI shows no errors
  • Unit tests passing

@mrbean-bremen mrbean-bremen merged commit 5283be6 into pytest-dev:main Mar 16, 2024
65 checks passed
@mrbean-bremen mrbean-bremen deleted the open_fd branch March 16, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The io.open function should not consider file permissions when opening from an existing file descriptor
1 participant