Unload all modules loaded during the test #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mrbean-bremen
commented
Nov 15, 2019
mrbean-bremen
commented
- these module can still hold references to fake modules
- modules already loaded at test start are not affected
- see disutil commands fails for multiple tests #501 and [3.4.3] Multiple tests in TestCase fail when not run in debug - shutil.make_archive #427
- these module can still hold references to fake modules - modules already loaded at test start are not affected - see pytest-dev#501 and pytest-dev#427
|
@jmcgeheeiv - please have a look. This shall fix the mentioned problems, but I would like to have a second opinion on probable problems/side effects this could cause. |
jmcgeheeiv
approved these changes
Nov 16, 2019
|
Well, now I've done it. I changed a comment and now it fails a test. Comments? |
You made an error in your correction: I recently (while handling #500) activated the flake8 test (put here by a contributor) so that is fails the build if it has warnings. This is a bit over the top, and I can deactivate it again - it was more of an experiment anyway. |
mrbean-bremen
force-pushed
the
unload-modules
branch
from
c9638b7 to
0215fa9
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.