Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed patch behavior to rely on module names instead of imported names #434

Merged
merged 3 commits into from
Oct 18, 2018
Merged

Changed patch behavior to rely on module names instead of imported names #434

merged 3 commits into from
Oct 18, 2018

Conversation

mrbean-bremen
Copy link
Member

  • adapted tests and documentation

@mrbean-bremen
Copy link
Member Author

@jmcgeheeiv - please check if you see any potential problems with this approach.
The performance is slighly worse because of the added dict lookup, but still acceptable in my opinion.

@mrbean-bremen mrbean-bremen force-pushed the module-patch branch 2 times, most recently from d29530a to 4f125ad Compare October 1, 2018 18:42
@mrbean-bremen mrbean-bremen force-pushed the module-patch branch 2 times, most recently from 1f1c939 to 37423a5 Compare October 17, 2018 18:34
@jmcgeheeiv jmcgeheeiv merged commit 97c9f64 into pytest-dev:master Oct 18, 2018
@mrbean-bremen mrbean-bremen deleted the module-patch branch October 30, 2018 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcgeheeiv jmcgeheeiv jmcgeheeiv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrbean-bremen @jmcgeheeiv