shutil.rmtree failing in OSType.WINDOWS with PermissionError

[gsnedders]

Describe the bug

I expect this to succeed, and not fail.

Traceback (most recent call last):
  File "/private/var/folders/qk/hmjj9_lx2cg3_4v3vx3y7y_w0000gn/T/tmp.L4ZwvgaUdy/test.py", line 12, in <module>
    shutil.rmtree("C:\\test.checkout\\LayoutTests\\imported\\w3c")
  File "/opt/homebrew/Cellar/[email protected]/3.12.2_1/Frameworks/Python.framework/Versions/3.12/lib/python3.12/shutil.py", line 781, in rmtree
    onexc(os.open, path, err)
  File "/opt/homebrew/Cellar/[email protected]/3.12.2_1/Frameworks/Python.framework/Versions/3.12/lib/python3.12/shutil.py", line 778, in rmtree
    fd = os.open(path, os.O_RDONLY, dir_fd=dir_fd)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/var/folders/qk/hmjj9_lx2cg3_4v3vx3y7y_w0000gn/T/tmp.L4ZwvgaUdy/venv/lib/python3.12/site-packages/pyfakefs/fake_os.py", line 1353, in wrapped
    return f(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^
  File "/private/var/folders/qk/hmjj9_lx2cg3_4v3vx3y7y_w0000gn/T/tmp.L4ZwvgaUdy/venv/lib/python3.12/site-packages/pyfakefs/fake_os.py", line 290, in open
    fake_file = FakeFileOpen(
                ^^^^^^^^^^^^^
  File "/private/var/folders/qk/hmjj9_lx2cg3_4v3vx3y7y_w0000gn/T/tmp.L4ZwvgaUdy/venv/lib/python3.12/site-packages/pyfakefs/fake_open.py", line 97, in __call__
    return self.call(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/var/folders/qk/hmjj9_lx2cg3_4v3vx3y7y_w0000gn/T/tmp.L4ZwvgaUdy/venv/lib/python3.12/site-packages/pyfakefs/fake_open.py", line 205, in call
    self.filesystem.raise_os_error(errno.EACCES, file_path)
  File "/private/var/folders/qk/hmjj9_lx2cg3_4v3vx3y7y_w0000gn/T/tmp.L4ZwvgaUdy/venv/lib/python3.12/site-packages/pyfakefs/fake_filesystem.py", line 427, in raise_os_error
    raise OSError(err_no, message, filename)
PermissionError: [Errno 13] Permission denied in the fake filesystem: 'C:\\test.checkout\\LayoutTests\\imported\\w3c'

How To Reproduce

import os
import shutil

from pyfakefs.fake_filesystem import OSType
from pyfakefs.fake_filesystem_unittest import Patcher

with Patcher() as patcher:
    fs = patcher.fs
    fs.os = OSType.WINDOWS

    os.makedirs("C:\\test.checkout\\LayoutTests\\imported\\w3c\\resources")
    shutil.rmtree("C:\\test.checkout\\LayoutTests\\imported\\w3c")

Your environment

% python -c "import platform; print(platform.platform())"
python -c "import sys; print('Python', sys.version)"
python -c "from pyfakefs import __version__; print('pyfakefs', __version__)"
python -c "import pytest; print('pytest', pytest.__version__)"
macOS-14.4-arm64-arm-64bit
Python 3.12.2 (main, Feb  6 2024, 20:19:44) [Clang 15.0.0 (clang-1500.1.0.2.5)]
pyfakefs 5.3.5
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'pytest'

[mrbean-bremen]

Thanks for the report!

[mrbean-bremen]

Should be fixed in main now, please check!

It may still be some time until the next release, as there are a few issues I want to handle before that.