Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading from fake block devices doesn't work #24

Closed
GoogleCodeExporter opened this issue Mar 16, 2015 · 1 comment
Closed

Reading from fake block devices doesn't work #24

GoogleCodeExporter opened this issue Mar 16, 2015 · 1 comment
Labels
bug

Comments

@GoogleCodeExporter
Copy link 

What steps will reproduce the problem?
1. Create a fake block device (dev = fs.CreateFile('name', stat.S_IFBLK))
2. Try and read from it (dev.read())


What is the expected output? What do you see instead?
This should work, but an error is raised about trying to read from a directory.

Patch with fix and test attached.

Original issue reported on code.google.com by [email protected] on 12 Dec 2013 at 3:13

Attachments:
dougluce added a commit to dougluce/pyfakefs that referenced this issue Jan 14, 2016
@dougluce
Use proper checking for directory on open.
4da5589 
So block devices aren't accidentally considered directories.  Should
address pytest-dev#24.
@dougluce dougluce mentioned this issue Jan 14, 2016
Merged
@jmcgeheeiv
Copy link
Contributor

Fixed by @dougluce in pull request #67.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmcgeheeiv @mrbean-bremen @GoogleCodeExporter