Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fake implementation of os.path.samefile #193

Closed
mrbean-bremen opened this issue May 28, 2017 · 2 comments · Fixed by #201
Closed

Add fake implementation of os.path.samefile #193

mrbean-bremen opened this issue May 28, 2017 · 2 comments · Fixed by #201
Assignees
@mrbean-bremen
Labels
enhancement

Comments

@mrbean-bremen
Copy link
Member

This is used in the implementation of shutil.

See #189.
This was referenced May 28, 2017
Closed
Closed
@jmcgeheeiv
Copy link
Contributor

I'm shocked that this does not already exist. This is important.

@mrbean-bremen
Copy link
Member Author

Yes - I thought I implemented this one, but it turned out that was only in fake_pathlib.

@mrbean-bremen mrbean-bremen self-assigned this Jun 9, 2017
mrbean-bremen added a commit to mrbean-bremen/pyfakefs that referenced this issue Jun 10, 2017
@mrbean-bremen
Added support for fake os.path.samefile
2e51917 
- fixes pytest-dev#193
@mrbean-bremen mrbean-bremen mentioned this issue Jun 10, 2017
Merged
mrbean-bremen added a commit to mrbean-bremen/pyfakefs that referenced this issue Jun 12, 2017
@mrbean-bremen
Added support for fake os.path.samefile
27ff519 
- fixes pytest-dev#193
jmcgeheeiv pushed a commit that referenced this issue Jun 13, 2017
@mrbean-bremen @jmcgeheeiv
Added support for fake os.path.samefile (#201)
06714c7 
- fixes #193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrbean-bremen mrbean-bremen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for fake os.path.samefile mrbean-bremen/pyfakefs
2 participants
@jmcgeheeiv @mrbean-bremen