Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.7 #193

Merged
merged 1 commit into from
Jul 23, 2018
Merged

Support Python 3.7 #193

merged 1 commit into from
Jul 23, 2018

Conversation

yan12125
Copy link
Contributor

Closes #192

@yan12125 yan12125 mentioned this pull request Jul 10, 2018
Closed
@yan12125 yan12125 closed this Jul 23, 2018
@yan12125 yan12125 reopened this Jul 23, 2018
@yan12125 yan12125 changed the title tox: add py37 configurations Support Python 3.7 Jul 23, 2018
@yan12125
Copy link
Contributor Author

Seems the previous test failure is a temporary issue. I've added Python 3.7 tests on AppVeyor (not on Travis CI yet due to less-than-ideal support for Python 3.7) and they run fine. I've also added explicit declarations for Python 3.7 support.

nicoddemus
nicoddemus approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yan12125! I've been meaning to get to this once Travis provided native 3.7 support, but this is taking more than I hoped.

@nicoddemus nicoddemus merged commit 8a4e741 into pytest-dev:master Jul 23, 2018
@yan12125 yan12125 deleted the patch-1 branch July 23, 2018 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yan12125 @RonnyPfannschmidt @nicoddemus