Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to new style classes (object inheritance) - Issue #44 #46

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Moving to new style classes (object inheritance) - Issue #44 #46

merged 1 commit into from
Feb 16, 2017

Conversation

MichalTHEDUDE
Copy link
Contributor

Adding to all classes inheritance from object class.

All test green, excepts for Interpreters:

  • python2.6
  • python3.4
  • pypy

as I don't have them.
Hope it isn't an issue :)

@nicoddemus
Copy link
Member

Not at all, we have AppVeyor and Travis to test across all interpreters and configurations required. Thanks again!

@hpk42
Copy link
Contributor

hpk42 commented Feb 16, 2017

Is there any particular reason to move to new style classes? I typically try to use a subset of python such that it doesn't matter if a class derives from object. In fact i rarely use inheritance anyway :)

@nicoddemus
Copy link
Member

nicoddemus commented Feb 16, 2017

This has been discussed in pytest-dev/pytest#2147, old-style classes introduce subtle differences that, granted, are hard to come by, but since it is simple to make it consistent across all versions we decided to just make them all new-style explicitly.

@goodboy
Copy link
Contributor

goodboy commented Feb 16, 2017

@hpk42 @nicoddemus it's an interesting point too because in py3 old-style don't exist any more and the syntax is equivalent.

@hpk42 hpk42 merged commit cf059aa into pytest-dev:master Feb 16, 2017
@hpk42
Copy link
Contributor

hpk42 commented Feb 16, 2017

oki. could you directly commit a changelog entry?

@goodboy
Copy link
Contributor

goodboy commented Feb 16, 2017

oh yey and now I have to rebase everything lolz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants