[RFC] multicall: hookwrapper: use yielded results, support firstresult=True #246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: pytest-dev/pytest#5301 (comment)
Currently results from a hookwrapper are ignored, this changes the behavior (see
test_hookwrapper_order
).Should this be explicitly enabled, e.g. via a new "use_hookwrapper_result" kwarg for the hookwrapper? As the existing test shows "yield" might be used with a result, which currently is ignored.
A hookwrapper currently can set the return value / outcome via
force_result
, but it would still run non-hookwrappers before.