Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update karateclub dependency for NetworkX 3.3 support #49

Closed
ffl096 opened this issue Oct 15, 2024 · 0 comments · Fixed by #51
Closed

Update karateclub dependency for NetworkX 3.3 support #49

ffl096 opened this issue Oct 15, 2024 · 0 comments · Fixed by #51
Labels
dependencies Pull requests that update a dependency file
Milestone

Comments

@ffl096
Copy link
Member

ffl096 commented Oct 15, 2024

Currently, TopoEmbedX is stuck on NetworkX 2.8 due to a transient dependency by the karateclub package. This has since been fixed on their end (benedekrozemberczki/karateclub#150).
This complicates installing TopoEmbedX, as the user most likely has a newer version of NetworkX installed in their environment already (e.g., simply because they installed TopoNetX). PIP does not downgrade the dependency automatically, leading to a dependency resolution error.

Notice that their PyPI release is severely outdated (from two years ago), but we fix karateclub to a specific (newer) commit right now anyway:

"karateclub @ git+https://github.com/benedekrozemberczki/karateclub@d35e05526455599688f1c4dd92e397cf92316ae4",

What to do

  • Update the pinned commit of karateclub to a commit after they updated their dependencies.
  • Check that everything works.
@ffl096 ffl096 added the dependencies Pull requests that update a dependency file label Oct 15, 2024
@ffl096 ffl096 added this to the 0.1.0 milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant