Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update karateclub dependency #51

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Update karateclub dependency #51

merged 1 commit into from
Oct 18, 2024

Conversation

ffl096
Copy link
Member

@ffl096 ffl096 commented Oct 15, 2024

This pull request updates karateclub to the latest state of their GitHub repository. The version on PyPI is severely outdated and not usable for us. Main benefit of this is that TopoEmbedX finally moves from NetworkX 2.8 to 3.3+, making installation way easier.

Closes #49.

@ffl096 ffl096 added the dependencies Pull requests that update a dependency file label Oct 15, 2024
@ffl096 ffl096 added this to the 0.1.0 milestone Oct 15, 2024
@ffl096 ffl096 requested a review from mhajij October 15, 2024 14:10
@ffl096 ffl096 self-assigned this Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (7fe74c9) to head (11312bf).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files           8        8           
  Lines         170      170           
=======================================
  Hits          164      164           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffl096 ffl096 force-pushed the frantzen/update-karateclub branch from e87c598 to 11312bf Compare October 15, 2024 14:15
@ffl096 ffl096 merged commit 80acf21 into main Oct 18, 2024
8 checks passed
@ffl096 ffl096 deleted the frantzen/update-karateclub branch October 18, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update karateclub dependency for NetworkX 3.3 support
1 participant