Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor refactoring to address all of the current FutureWarnings and PytestUnknownMarkWarning raised by the tests. This wrangles a few references to
delim_whitespace
that slipped through the cracks in addition to many instances of the follow warnings:FutureWarning: The behavior of DataFrame concatenation with empty or all-NA entries is deprecated.
FutureWarning: Downcasting object dtype arrays on .fillna, .ffill, .bfill is deprecated and will change in a future version.
FutureWarning: Setting an item of incompatible dtype is deprecated and will raise an error in a future version of pandas.
PytestUnknownMarkWarning: Unknown pytest.mark.uses_geopandas
After these changes, warnings raised when running tests should reduce from 107 to 15.
Note
The remaining 15 warnings are raised by
swmmio
itself, in situations where thedataframe_from_inp
function attempts to extract a section of the INP that is not found. For example:I'm tired of seeing these warnings too. But in some cases these may be important. Maybe we can provide a user config that optionally silences these? I'm open to ideas. But we can tackle that separately