Fix permissions when env user cannot be used for ssh login #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-blanchard
force-pushed
the
fix/permissions_issues_update_virtualenv
branch
from
9a7a6d2
to
b19d3d8
Compare
|
Is there anything blocking the merge of this PR? |
|
It needs to be expanded upon for backward compatibility. I was planning on adding new settings so you can specify the user that the virtualenv creation/deletion commands run as independently of the SSH user. |
|
I'm happy to make the remaining necessary changes here if you can convey some more specific idea of what's left to be done, @dan-blanchard. |
|
I can add it just as quickly as I could explain it, so I'll just bang it out. |
dan-blanchard
force-pushed
the
fix/permissions_issues_update_virtualenv
branch
from
b19d3d8
to
5a36b5e
Compare
dan-blanchard
force-pushed
the
fix/permissions_issues_update_virtualenv
branch
4 times, most recently
from
6986994
to
5dc2f22
Compare
dan-blanchard
force-pushed
the
fix/permissions_issues_update_virtualenv
branch
from
5dc2f22
to
e80b327
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible for you to use your own user account as the SSH login account for a server and then sudo to a different user for creating virtualenvs. This handles the common scenario where the superuser that you need to use to write the virtualenv is not a login account.