Merge pull request #501 from maciej-lech/master

Fix util.py:nimbus_storm_version
pystorm · Aug 9, 2024 · e115ac5 · e115ac5
2 parents af44ba3 + 8534f5a
commit e115ac5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/streamparse/util.py b/streamparse/util.py
@@ -382,17 +382,17 @@ def nimbus_storm_version(nimbus_client):
     """Get the Storm version that Nimbus is reporting, if it's reporting it.
 
     :returns: Storm version that Nimbus is reporting, if it's reporting it.
-              Will return `LegacyVersion('')` if it's not reporting anything.
+              Will return `Version('0.0.0')` if it's not reporting anything.
     :rtype: pkg_resources.Version
     """
-    version = parse_version("")
+    version = "0.0.0"
     nimbuses = nimbus_client.getClusterInfo().nimbuses
     if nimbuses is not None:
         for nimbus in nimbuses:
             if nimbus.version != "VERSION_NOT_PROVIDED":
-                version = parse_version(nimbus.version)
+                version = nimbus.version
                 break
-    return version
+    return parse_version(version)
 
 
 def storm_lib_version():

diff --git a/streamparse/version.py b/streamparse/version.py
@@ -21,7 +21,7 @@
 
 
 def _safe_int(string):
-    """ Simple function to convert strings into ints without dying. """
+    """Simple function to convert strings into ints without dying."""
     try:
         return int(string)
     except ValueError: