Fix aiohttp benchmark on Python 3.11 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrades cython to a version that is compatible with Python 3.11, and then uses `--no-binary` on `uvloop` and `yarl` to force a "re-Cythonization" of the package. I could understand if one doesn't want to merge this, since we would be testing a local build of these packages rather than official upstream wheel. However, this does get things working in the meantime.
|
Seems good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades cython to a version that is compatible with Python 3.11, and then
uses
--no-binaryonuvloopandyarlto force a "re-Cythonization" of thepackage.
I could understand if one doesn't want to merge this, since we would be testing
a local build of these packages rather than official upstream wheel. However,
this does get things working in the meantime.
EDIT:
yarlalready has a working release, so just updated to that.uvlooprequires this "hack" still.