This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
Add slack block interactions #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovv
suggested changes
Jun 11, 2019
There was a problem hiding this comment.
Only a small change and good to go.
The travis failure is due to the new version of isort. Running tox should fix it.
Otherwise the change needed is
--- a/sirbot/plugins/postgres/plugin.py
+++ b/sirbot/plugins/postgres/plugin.py
@@ -1,10 +1,10 @@
import os
import logging
+import ujson
import asyncpg
import aiofiles
from aiocontext import async_contextmanager
-import ujson
LOG = logging.getLogger(__name__)
Thanks for the PR 👍
sirbot/plugins/slack/plugin.py
Outdated
| @@ -141,20 +141,57 @@ def on_message( | |||
| pattern=pattern, handler=(handler, configuration), **kwargs | |||
| ) | |||
|
|
|||
| def on_action(self, action, handler, name="*", wait=True): | |||
| def on_action(self, callback_id, handler, name="*", wait=True): | |||
There was a problem hiding this comment.
I would keep action here. Only to not break compatibility
There was a problem hiding this comment.
Ah, true. Wasn't thinking about keyword args.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Slack's new Block-based interactive messages. (accompanying
slack-sansioPR)Adds
on_blockandon_dialog_submissionmethods for registering actions of the corresponding types.