last_element_min_time

[clavay]

set min time to 0 if no min time is set

[clavay]

@trombastic What do you think about changing this behavior ?

[trombastic]

this seems to be a good choice for the default value in general, how ever this will return all data if no time_min is provided and this will take a lot of time if used accidentally on a large dataset. Do you know if this method is used without time_min in a view?

[clavay]

the function last_element returns only one element, the last one in the time range.

it is used with time_min=0 here:

PyScada/pyscada/models.py

Lines 604 to 609 in 83ae3f2

	last_element = self.last_element(
	use_date_saved=True,
	time_min=0,
	time_max=time_max_last_value,
	variable_id=pk,
	)

it should be used with time_min=0 here:

PyScada/pyscada/models.py

Line 3715 in 83ae3f2

actual_value = RecordedData.objects.last_element(variable=self.variable)

PyScada/pyscada/models.py

Lines 3725 to 3727 in 83ae3f2

	limit_value = RecordedData.objects.last_element(
	variable=self.variable_limit
	)

PyScada/pyscada/admin.py

Line 602 in 83ae3f2

element = RecordedData.objects.last_element(variable_id=instance.pk)