Js fixes and updates #78
Conversation
set first calendar day to monday
check if the span field with class .boolean-value exist before writting the value for svg process flow diagram item the method is different so the span does not exist todo : replace value by string for process diagram items
check if '#aggregation-type-all-select-' + widget_id exist before adding new option
| @@ -2802,7 +2802,7 @@ function createOffset(date) { | |||
| "November", | |||
| "December" | |||
| ], | |||
| "firstDay": 1 | |||
| "firstDay": 0 | |||
There was a problem hiding this comment.
this is only the default in most of europe, maybe it ist better to get that info from the locaton settings of the browser?
There was a problem hiding this comment.
Do you know how and compatible with many browsers ?
There was a problem hiding this comment.
There was a problem hiding this comment.
As the current config is "daysOfWeek": [ "Mo", "Tu", "We", "Th", "Fr", "Sa", "Su", ],
The current setting is showing Tuesday as the first day of the week.
So we can change it to Monday or Sunday till we found how to set it accordingly to the browser settings.
This PR propose Monday.
There was a problem hiding this comment.
I add a new commit to correct a bug about naming the days.
The day list in the JS datetimepicker config should start on sunday.
I think you can approve this request to fix this bug and then we plan in github discussion or project to get the browser locale to set the first week day.
What do you think @trombastic ?
The daysOfWeek order for DateTimePicker should start on sunday, if not the days are not well labeled Then the firstDay select the first day to start weeks in the calendar The first day is set to monday untill we find how to get the browser locale and use the first week day for that country
set first calendar day to monday
check if the span field with class .boolean-value exist before writting
the value
for svg process flow diagram item the method is different so the span
does not exist
todo : replace value by string for process diagram items
check if '#aggregation-type-all-select-' + widget_id exist before adding
new option