Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stopping BP if not exist while deleting a device #123

Merged
merged 1 commit into from
Feb 12, 2024
Merged

fix stopping BP if not exist while deleting a device #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions pyscada/signals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,12 +133,16 @@ def _del_daq_daemons(sender, instance, **kwargs):
label=f"pyscada.{instance.protocol.protocol}-{instance.id}",
)
except BackgroundProcess.DoesNotExist:
# for modbus protocol
bp = BackgroundProcess.objects.get(
done=False,
failed=False,
label__startswith=f"pyscada.{instance.protocol.protocol}-{instance.id}",
)
try:
# for modbus protocol
bp = BackgroundProcess.objects.get(
done=False,
failed=False,
label__startswith=f"pyscada.{instance.protocol.protocol}-{instance.id}",
)
except BackgroundProcess.DoesNotExist:
# BP not created, cannot stop
return False
except Exception as e:
logger.debug(e)
return False
Expand Down