replace save method by get_or_create for dictionary items

don't create it if it already exist
pyscada · Oct 16, 2023 · 20961c6 · 20961c6
1 parent 67187cf
commit 20961c6
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/pyscada/models.py b/pyscada/models.py
@@ -1190,9 +1190,9 @@ def convert_string_value(self, value):
             max_value = 0
             for di in self.dictionary.dictionaryitem_set.all():
                 max_value = max(float(max_value), float(di.value))
-            DictionaryItem(
+            DictionaryItem.objects.get_or_create(
                 label=str(value), value=int(max_value) + 1, dictionary=self.dictionary
-            ).save()
+            )
             # logger.debug('new value : %s' % (int(max_value) + 1))
             return int(max_value) + 1
         elif len(self.dictionary.dictionaryitem_set.filter(label=str(value))) == 1:
@@ -1760,11 +1760,11 @@ def convert_string_value(self, value):
                 max_value = 0
                 for di in self.dictionary.dictionaryitem_set.all():
                     max_value = max(float(max_value), float(di.value))
-                DictionaryItem(
+                DictionaryItem.objects.get_or_create(
                     label=str(value),
                     value=int(max_value) + 1,
                     dictionary=self.dictionary,
-                ).save()
+                )
                 # logger.debug('new value : %s' % (int(max_value) + 1))
                 return int(max_value) + 1
             elif len(self.dictionary.dictionaryitem_set.filter(label=str(value))) == 1: