Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with_ref and with_query args for get_aligned_pairs. #777

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

y9c
Copy link

@y9c y9c commented Mar 23, 2019

  • with_seq argument is misleading.
  • add with_query will make pysam more powerful.

`with_seq` argument will be deprecated.
@AndreasHeger
Copy link
Contributor

AndreasHeger commented Jun 19, 2019

Thanks, @yech1990 , I agree that with_seq is not a fortunate name and with_ref is better.
However, leaving the query sequence out was intentional as it is easy obtained using the query sequence stored in the read, while getting the reference base is trickier.

@y9c
Copy link
Author

y9c commented Nov 15, 2024

More related issues

#1294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants