Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added tooltip for timeline selection #730

Merged
merged 10 commits into from
Jan 24, 2022

Conversation

shaleynikov
Copy link
Contributor

@shaleynikov shaleynikov commented Jan 14, 2022

This is a contribution for #99

@shaleynikov shaleynikov changed the title feat(frontend): added tooltip for timeline selection feat(frontend) added tooltip for timeline selection Jan 14, 2022
@shaleynikov shaleynikov changed the title feat(frontend) added tooltip for timeline selection feat: added tooltip for timeline selection Jan 14, 2022
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #730 (042e26d) into main (a941634) will decrease coverage by 3.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
- Coverage   76.09%   73.02%   -3.06%     
==========================================
  Files          60       63       +3     
  Lines        2070     2257     +187     
  Branches      431      487      +56     
==========================================
+ Hits         1575     1648      +73     
- Misses        465      570     +105     
- Partials       30       39       +9     
Impacted Files Coverage Δ
...mponents/FlameGraph/FlameGraphComponent/Header.tsx 67.45% <0.00%> (-23.03%) ⬇️
...components/FlameGraph/FlameGraphComponent/color.ts 78.13% <0.00%> (-16.42%) ⬇️
...lameGraph/FlameGraphComponent/Flamegraph_render.ts 96.86% <0.00%> (-0.09%) ⬇️
...nts/FlameGraph/FlameGraphComponent/colorPalette.ts 100.00% <0.00%> (ø)
webapp/javascript/components/ExportData.tsx 45.72% <0.00%> (ø)
webapp/javascript/util/updateRequests.js 0.00% <0.00%> (ø)
...nents/FlameGraph/FlameGraphComponent/Flamegraph.ts 93.75% <0.00%> (+0.04%) ⬆️
...ents/FlameGraph/FlameGraphComponent/DiffLegend.tsx 89.48% <0.00%> (+0.29%) ⬆️
...omponents/FlameGraph/FlameGraphComponent/index.tsx 85.00% <0.00%> (+0.96%) ⬆️
webapp/javascript/util/formatDate.js 58.07% <0.00%> (+5.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a941634...042e26d. Read the comment docs.

@petethepig
Copy link
Member

Looks great! The only thing I could find is it should add a zero before 5 in 10:05
Screen Shot 2022-01-14 at 10 55 09 AM

@Rperry2174
Copy link
Contributor

Hey @shaleynikov everything looks good here. Could you add a simple unit test that:

  • Creates a hover event
  • Checks that the tooltip exists on-hover

@Rperry2174
Copy link
Contributor

hey @shaleynikov currently when selecting a time range on the graph, there are two tooltips on the bottom while the mouse is down.

Can you make it so that there is only one (at the current location of the mouse)
2022-01-23 14 06 03

@Rperry2174 Rperry2174 merged commit d226370 into grafana:main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants