Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve timeline selector UI/UX #953

Closed
Rperry2174 opened this issue Mar 18, 2022 · 0 comments
Closed

Improve timeline selector UI/UX #953

Rperry2174 opened this issue Mar 18, 2022 · 0 comments
Assignees

Comments

@Rperry2174
Copy link
Contributor

Rperry2174 commented Mar 18, 2022

As of right now when selecting a time range on the timeline on comparison and diff page , it's not completely clear that a user has the ability to interact with the timeline.

I.e. these two arrows point to parts of the flamegraph that a user can interact with:
image

the image above is from #942 where we also changed the colors of the comparison timelines to distinguish between two separate queries.

I think a much nicer version of this can be seen in this UI with lightstep:
image

There are two components of the timeline above that we should adopt to improve on two elements of UX with these timelines:

  1. To much use of a single color
  2. Not clear that timeline is interactable

Fixing too much use of a single color

Lets use the "left" timeline for an example:
image

there are multiple elements that are pink:
image

  1. The data bars themselves are pink
  2. The "end bars" (red text) are pink -- which is kind of confusing compared to the pink bars which also denote actual data
  3. The "shaded selected area" is a slightly opaque pink

The same is true for the blue timeline...

In order to fix this I think we should:

  1. Leave the data bars themselves as pink
  2. make the end bars "dashed" grey (lets make this configurable so we can play with different colors)
  3. make the "shaded selected area" a slightly opaque grey

Maybe add a "pink" horizontal bar along the top edge of the selected area similar to the purple horizontal bar in this image:
image

Fixing making it clear that the timeilne is interact-able

This one is more straight forward. I think we simply need to:

  1. Add the "handle" on the left and the right side of the range to make it clear that people can change this
  2. Remove the text that says "select left time range" because now hopefully it will be clearer

Considerations

This will likely require us to make these changes via a custom flot plugin similar to what @shaleynikov did in fixing #99 / #730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants