Update jax.tree_util.tree_map to jax.tree.map #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
martinjankowiak
approved these changes
Jun 26, 2024
| @@ -1417,7 +1415,7 @@ def _inverse(self, y: jnp.ndarray) -> jnp.ndarray: | |||
| return y | |||
|
|
|||
| def extend_axis_rev(self, array: jnp.ndarray, axis: int) -> jnp.ndarray: | |||
| normalized_axis = normalize_axis_tuple(axis, array.ndim)[0] | |||
| normalized_axis = axis if axis >= 0 else jnp.ndim(array) + axis | |||
There was a problem hiding this comment.
what about this change?
There was a problem hiding this comment.
This raises a warning that this function is hidden and accessing it through numpy.core.numeric is deprecated.
|
The current numpy versions still use a_min a_max. They have a PR to deprecate those arguments but it has not been merged yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since jax 0.4.25 (released Feb 24),
jax.tree_util.tree_mapis deprecated, in favor ofjax.tree.map. This PR updates numpyro to use the new pattern.In addition,
jnp.clip(..., a_min=..., a_max=...)is deprecated. I change the pattern tojnp.clip(..., ..., ...)to remove the deprecation warning in the tests.