Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation 2 #959
Improve documentation 2 #959
Changes from 36 commits
24bad19
9c069a3
d2b1b5c
63e81f0
f9d318e
f4e67b8
c81c20f
4894035
6f11677
effcbd0
2d4dbbf
05914ce
ab04b79
5955764
3478b01
3523204
62b374a
56029f2
290abb7
a0adcf2
e54b36f
8e3226d
11c5962
8fd77e0
96aceb8
3f49938
81f504c
089978c
e2fa48d
8909c8f
67f944d
2c16736
1ad3910
67bb69c
8febaa5
e78bae4
84c9965
e8746f3
2a877e1
5c11ab9
fb44e5f
af14e03
56cdf3f
202f369
bb917f9
54513db
323c2bb
b455169
4767ad6
85494c2
99475cd
38df89c
7766390
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could make sense to add an extension to the file name:
config.default.yaml
(not crucial, just for consistency)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not specify this here, hopefully soon we can have this fix, and I'd keep this description easy for the time being. What do you think?
Instead, I'd move this comment below at the bottom of the section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will move Copernicus setup to the section where build_cutout is explained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't
date range
instead ofdata range
be more specific?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could make sense to fix a typo: ->
prediction_year
correspondsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd move up this section up in the list.
It is good to explain well how to use these blocks and in particular recommend the deactivation of retrieve_databundle after the first run.
Moreover, I agree it is worth mentioning when to run build cutout.
Note that now build_natura_raster may be better false by default (it is so in the default configuration)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, I will move enable block upward and explain it a little bit more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove the reference to the Oceania region to be honest, to simplify the reading.
The users may say "why oceania" and it may be confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it might be confusing. I will remove particular reference to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This guide may be the first point of the overall list rather than the 3rd, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this section we shall reference the validation and ok to reference the custom_validation file and how to feed-in custom data for users that do have country-specific data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we if put this section in the front, it will create more questions than answering them. It will require expanding this page to fill the gaps and explain everything, which defies its main purpose -- to be concise summary. Expanding it make it close to current
Basic customization
page. If we do not expand people may think what isnatura.tiff
andcutouts
. I think a sole purpose of this section to give brief summary of steps, not introduction. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have included the validation part as suggeted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a refence, as discussed today, it may be good to revise this steps as a preliminary introduction for the overall full tutorial, while moving more advanced concepts into the relative steps.
Great Yerbol :D This seems the last step to finalize. Congratulations!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made it as short summary of Model customization section for better navigation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd revise the title into "Check if custom cutout is necessary".
Here we mention that we provide a cutout for every continent for year 2013; if you need a different year or a more complex region, then you may desire to create your own, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, noted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
point 3.
The default natura tiff is now a CC0 data: Sosa Arango, Chrystian Camilo, 2020, "Protected areas (WDPA)", https://doi.org/10.7910/DVN/XIV9BL, Harvard Dataverse, V1
While if you enable the building, we rely on WPDA database, the user shall make sure to adhere to the data license and it is worth mentioning the computational time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will include this information.