-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove duplicated config entry #1288
Conversation
@ekatef I removed an entry in the config file ("hydrogen_underground_storage"), which wasnt used at all as we use "[sector][hydrogen][underground_storage]". Can you review and merge it / also merge it to your config PR? :) |
I'm also unsure about the entries gadm_layer_id and gadm_level, but they are both used. @ekatef do you know the difference between those? |
Hello @doneachh, that is an amazing idea to clean-up the config! Thanks a lot for addressing My feeling is that it would facilitate implementation of the modeling approach for the config. The point is we can easily have some side effects from interactions between some config parameters. If you see any way to improve it, that would be very much appreciated.
My understanding is that it has been a difference between the power and sector-coupled parts. For now, it looks like a duplication. Feel free to address it 🙂 If you have any other ideas to improve structure of the config, feel free to go ahead and ping me once you'd be satisfied with the result 🙂 |
@ekatef Alright! I addressed it and I would be happy to merge it! :) Somehow the CI for readthedocs failed, but i dont know why - do you know the reason? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekatef Great - thanks a lot for reviewing! All checks have passed - feel free to merge it! :) |
Closes # (if applicable).
Changes proposed in this Pull Request
In the config file was an entry "hydrogen_underground_storage", which wasnt used at all - we use "[sector][hydrogen][underground_storage]". I removed it!
Checklist
envs/environment.yaml
anddoc/requirements.txt
.config.default.yaml
andconfig.tutorial.yaml
.test/
(note tests are changing the config.tutorial.yaml)doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.