Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add myopic optimization #318

Merged
merged 20 commits into from
Jul 15, 2024
Merged

Add myopic optimization #318

merged 20 commits into from
Jul 15, 2024

Conversation

davide-f
Copy link
Member

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f
Copy link
Member Author

This PR builds on #285 , priority shall be given to #285

@davide-f
Copy link
Member Author

@energyLS FYI :)

@Eddy-JV Eddy-JV self-requested a review May 31, 2024 08:36
@energyLS
Copy link
Collaborator

energyLS commented Jul 4, 2024

I will take over and review this PR

@energyLS energyLS self-requested a review July 4, 2024 14:23
Copy link
Collaborator

@energyLS energyLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. I did not review "add_existing_baseyear.py" and "add_brownfield.py" yet. Currently trying to run it locally.

Snakefile Outdated Show resolved Hide resolved
Snakefile Show resolved Hide resolved
Snakefile Show resolved Hide resolved
Snakefile Show resolved Hide resolved
Snakefile Show resolved Hide resolved
scripts/add_brownfield.py Show resolved Hide resolved
scripts/add_export.py Outdated Show resolved Hide resolved
scripts/prepare_sector_network.py Show resolved Hide resolved
scripts/prepare_sector_network.py Show resolved Hide resolved
@energyLS
Copy link
Collaborator

energyLS commented Jul 9, 2024

Testing locally and adding 2050 as well, I run into this error. Currently investigating.
grafik

Some more details: (it seems like the h2_network has some 2040 pipelines in there, which maybe shouldn't?)
grafik

@davide-f
Copy link
Member Author

davide-f commented Jul 9, 2024

Thanks! Leave it to me :)
I'd recommend to test: 2030 and 2050 as horizons (I tested them)

@energyLS
Copy link
Collaborator

energyLS commented Jul 9, 2024

Thanks! Leave it to me :) I'd recommend to test: 2030 and 2050 as horizons (I tested them)

Thanks, I will leave that to you

@energyLS
Copy link
Collaborator

energyLS commented Jul 9, 2024

however good news: Apart from that error in 2050, everything seems to work! I have added my replies to the threads, only minor things are open. @davide-f I am optimistic that we can merge soon once the final issues/questions are resolved.

@energyLS
Copy link
Collaborator

@davide-f do you require any additional support here?

@davide-f
Copy link
Member Author

This PR is ready to go and contains the fix for DF 2040 too.
It can be checked with pypsa-meets-earth/documentation#89

Copy link
Collaborator

@energyLS energyLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Great job @davide-f!

@energyLS energyLS merged commit f585dcc into main Jul 15, 2024
4 checks passed
@@ -119,6 +119,17 @@ solar_thermal:
slope: 45.
azimuth: 180.

existing_capacities:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@finozzifa see here for newly introduced config option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants