-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add myopic optimization #318
Conversation
for more information, see https://pre-commit.ci
@energyLS FYI :) |
I will take over and review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. I did not review "add_existing_baseyear.py" and "add_brownfield.py" yet. Currently trying to run it locally.
Thanks! Leave it to me :) |
Thanks, I will leave that to you |
however good news: Apart from that error in 2050, everything seems to work! I have added my replies to the threads, only minor things are open. @davide-f I am optimistic that we can merge soon once the final issues/questions are resolved. |
@davide-f do you require any additional support here? |
This PR is ready to go and contains the fix for DF 2040 too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Great job @davide-f!
@@ -119,6 +119,17 @@ solar_thermal: | |||
slope: 45. | |||
azimuth: 180. | |||
|
|||
existing_capacities: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@finozzifa see here for newly introduced config option
Closes # (if applicable).
Changes proposed in this Pull Request
Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
,config.tutorial.yaml
, andtest/config.test1.yaml
.doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.