REF: Remove network kwarg from Proj and Transformer #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question: do you then need to enable the network before creating the transformer object to have effect? Or can you switch back and forth for a single transformer object? |
Yes, you need to enable it before creating the transformer. It wouldn't be a good idea to allow toggling the network after it is enabled as it impacts how it is initialized. |
|
Ref: #629 (comment) |
snowman2
force-pushed
the
simplify
branch
2 times, most recently
from
d8b9b46 to
6d2010e
Compare
|
Did some tests with the global context to see what the behavior changes would be with toggling the network on the context of a transformer and it seems like it doesn't change results when toggling after initialization. Base script: import logging
import pyproj
from pyproj import Transformer
logging.basicConfig(format="%(levelname)s:%(message)s", level=logging.DEBUG)
pyproj.set_use_global_context(True)
lonlat = -74.9, 39.9
pyproj.network.set_network_enabled(True)
tr = Transformer.from_crs("epsg:4326", "esri:102003", always_xy=True)
albers_pt = tr.transform(*lonlat, errcheck=True)
print(f"Albers: {albers_pt}")
print(tr.is_network_enabled)
pyproj.network.set_network_enabled(False)
albers_pt = tr.transform(*lonlat, errcheck=True)
print(f"Albers: {albers_pt}")
print(tr.is_network_enabled)Initialized enabled. enable result == disable result: Initialized disabled. disable result == enable result: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally added in #637. Since then, #675 and #695 were added. With those additions, I think it make sense to remove the
networkkwarg because: