Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test upcoming Twine release (1.10.0rc1)? #203

Closed
brainwane opened this issue Mar 4, 2018 · 6 comments
Closed

Test upcoming Twine release (1.10.0rc1)? #203

brainwane opened this issue Mar 4, 2018 · 6 comments
Assignees

Comments

@brainwane
Copy link

https://test.pypi.org/project/twine/1.10.0rc1/ is a release candidate for Twine 1.10.0 which I'm planning to release early this week. Please see the changelog for detailed notes under "Next feature release".

I believe this is how you test it out on its own: pip install --upgrade --pre --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple twine

I would to hear about any problems this new release causes in pypiserver. And if there are some simple tests I can run before a new release to check whether a change in twine would break core functionality for you, maybe you could mention that on pypa/twine#314.

(By the way, I also work on Warehouse, the new codebase for https://pypi.org, and your list of similar projects in the README has been helpful to me! And I thought you might want to know about pypi/warehouse#3123 since it's about how your project's metadata renders on the new pypi.org.)

Thanks.

@mplanchard mplanchard self-assigned this Mar 5, 2018
@mplanchard
Copy link
Contributor

Thanks so much for reaching out!! I'm really glad to be able to collaborate to make sure that our users aren't adversely affected by updates.

I just moved on Friday, so things are a bit hectic around the house, but I will make it my top priority this week to find some time both to contribute to pypa/twine#314 and to run our full test suite against the RC.

And thanks for the heads up about pypi/warehouse#3123! I am personally very much looking forward to Warehouse's full rollout. From what I've seen, it's going to be a major improvement on the existing PyPI site.

Anyway, I'll get on this hopefully tonight or tomorrow night at the latest, and I'll post updates both here and in pypa/twine#314.

@ankostis
Copy link
Member

ankostis commented Mar 5, 2018

@mplanchard you may remove both our names and put yours as maintainer.

mplanchard added a commit that referenced this issue Mar 7, 2018
Resolves #203
Related to pypa/twine#314

This commit adds an ``sh -c`` call, whose argument is the value of the
environment variable ``PYPISERVER_SETUP_CMD``, or ``true`` if that
variable is not set. This was specifically added to enable the
``pre_twine`` environment, which is provided to automatically test
pre-releases of twine, both for our use (e.g. #203) and for the use of
the twine maintainers (pypa/twine#314).

The capacity to specify an arbitrary setup command via an environment
variable may also wind up being useful in other cases in the future.

In addition, the envlist is updated to include only Python versions we
actually support.

This commit also alphabetizes the ``dev.pip`` requirements and rmeoves
specific requirements for testing using Python 2.5 (which we do not test
against anymore).
mplanchard added a commit that referenced this issue Mar 7, 2018
Resolves #203
Related to pypa/twine#314

This commit adds an ``sh -c`` call, whose argument is the value of the
environment variable ``PYPISERVER_SETUP_CMD``, or ``true`` if that
variable is not set. This was specifically added to enable the
``pre_twine`` environment, which is provided to automatically test
pre-releases of twine, both for our use (e.g. #203) and for the use of
the twine maintainers (pypa/twine#314).

The capacity to specify an arbitrary setup command via an environment
variable may also wind up being useful in other cases in the future.

In addition, the envlist is updated to include only Python versions we
actually support.

This commit also alphabetizes the ``dev.pip`` requirements and rmeoves
specific requirements for testing using Python 2.5 (which we do not test
against anymore).
@mplanchard
Copy link
Contributor

@brainwane our existing test suite performs a twine upload, so I just added a tox environment in #204 that can be manually run to test with the current pre-release of twine against all supported Python runtimes with tox -e pre_twine. All of the tests passed with no problems on my local machine against the current twine RC, so seems like we're good to go!

@brainwane
Copy link
Author

Thank you very much for the advice and the testing! https://pypi.org/project/twine/1.10.0/ is now out!

@brainwane
Copy link
Author

And @mplanchard I hope you'll be at the PyCon sprints in May to collaborate with other packaging/distribution folks!

@mplanchard
Copy link
Contributor

@brainwane I wish I could be there! However, PyCon this year happens to fall right in the middle of my honeymoon, so I'm going to have to skip it 😉

Hopefully I'll be able to make another conference this year, or at least next year's PyCon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants