Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make endings of HTTP errors more consistent #7808

Merged
merged 2 commits into from
Jun 20, 2020
Merged

Make endings of HTTP errors more consistent #7808

merged 2 commits into from
Jun 20, 2020

Conversation

bhrutledge
Copy link
Contributor

I noticed these when writing up pypa/twine#587

  • Add missing periods
  • Use "for more information" on all URLs (since it seemed to be the more common pattern)

@bhrutledge
Copy link
Contributor Author

Ah, I was wondering if this would break the tests. I haven't set up a full development environment yet. Before I do that, I'm wondering how likely this is to get merged. @di @ewdurbin any thoughts?

@di
Copy link
Member

di commented Apr 17, 2020

@bhrutledge Sure, I'd merge this.

@bhrutledge bhrutledge mentioned this pull request Jun 18, 2020
Merged
@di
Copy link
Member

di commented Jun 19, 2020

@bhrutledge Still planning to update the tests here or should I close for now?

@bhrutledge
Copy link
Contributor Author

@di Hoping to do this, since pypa/twine#666 put it back on radar. Maybe this weekend?

@bhrutledge
Copy link
Contributor Author

@di The checks are passing. Thanks for the nudge.

@di di merged commit 9d17b01 into pypi:master Jun 20, 2020
@di
Copy link
Member

di commented Jun 20, 2020

Thanks!

@bhrutledge bhrutledge deleted the normalize-http-errors branch June 20, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhrutledge @di