warehouse, tests: devolve oidc.models
#13553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turns `oidc.models` into a directory, with `models.base` for the basic OIDC publisher classes and adjacent modules for each specific OIDC implementation (currently just GitHub). This will make adding additional OIDC publishers easier and cleaner, as each will live in its own dedicated submodule. Signed-off-by: William Woodruff <[email protected]>
8 tasks
woodruffw
commented
May 1, 2023
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
di
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns
oidc.modelsinto a directory, withmodels.basefor the basic OIDC publisher classes and adjacent modules for each specific OIDC implementation (currently just GitHub).This will make adding additional OIDC publishers easier and cleaner, as each will live in its own dedicated submodule.
See #13551.
CC @di