-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI?][i18n] Enable horizontal scroll for code blocks on PyPI #12529
Comments
The problem manifests in English as well: The content is located in this template: warehouse/warehouse/templates/manage/account/token.html Lines 98 to 111 in 1387d3a
The width of the overall content column is set in SCSS: warehouse/warehouse/static/sass/layout-helpers/_containers.scss Lines 28 to 29 in 1387d3a
I don't think it's likely to change the global width setting to accommodate this. Rather, it's more likely to explore adding the horizontal scroll to the specific code block SCSS https://github.com/pypi/warehouse/blob/1387d3a1212cb56feb114611cf44739f63707eb2/warehouse/static/sass/blocks/_code-block.scss |
Use same `pverflow-x` behavior we have in `project-description`. `code-block` classes are only used in the `token.html` template today. Fixes pypi#12529 Signed-off-by: Mike Fiedler <[email protected]>
Use same `pverflow-x` behavior we have in `project-description`. `code-block` classes are only used in the `token.html` template today. Fixes #12529 Signed-off-by: Mike Fiedler <[email protected]> Signed-off-by: Mike Fiedler <[email protected]>
Describe the bug
I noticed that the monotype text in a
.pypirc
example overflows the right border.I suppose it's because the translation string is longer than the original English one.
The problem of text not fitting in the UI is common
Expected behavior
I think that a horizontal scroll bar appearing in such code blocks would handle this case very well. The translators aren't immediately exposed to where and how the translation strings will be rendered. So it is unlikely for this to be fixed during the translation-time, only post-merge/build/deploy.
To Reproduce
It's on https://pypi.org/manage/account/token/.
My Platform
N/A
Additional context
The text was updated successfully, but these errors were encountered: