-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow fwhm_fromlines
for tilts calibration
#1861
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1861 +/- ##
========================================
Coverage 38.07% 38.07%
========================================
Files 211 211
Lines 49051 49064 +13
========================================
+ Hits 18675 18680 +5
- Misses 30376 30384 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very good, thanks!
@@ -268,24 +279,32 @@ class BuildWaveTilts: | |||
slits (:class:`~pypeit.slittrace.SlitTraceSet`): | |||
Slit edges | |||
spectrograph (:class:`~pypeit.spectrographs.spectrograph.Spectrograph`): | |||
Spectrograph object | |||
The `Spectrograph` instance that sets the instrument used. Used to set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for polishing these!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Approving now, but we need to run the tests.
Tests pass (the failed unit tests are the usual
|
As title. Addresses issue #1688
Also, a small fix to
pypeit_chk_tilts