Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fwhm_fromlines for tilts calibration #1861

Merged
merged 8 commits into from
Oct 29, 2024
Merged

Allow fwhm_fromlines for tilts calibration #1861

merged 8 commits into from
Oct 29, 2024

Conversation

debora-pe
Copy link
Collaborator

As title. Addresses issue #1688
Also, a small fix to pypeit_chk_tilts

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 31.57895% with 13 lines in your changes missing coverage. Please review.

Project coverage is 38.07%. Comparing base (2b53647) to head (7a3944e).

Files with missing lines Patch % Lines
pypeit/wavetilts.py 33.33% 10 Missing ⚠️
pypeit/scripts/chk_tilts.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1861   +/-   ##
========================================
  Coverage    38.07%   38.07%           
========================================
  Files          211      211           
  Lines        49051    49064   +13     
========================================
+ Hits         18675    18680    +5     
- Misses       30376    30384    +8     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good, thanks!

@@ -268,24 +279,32 @@ class BuildWaveTilts:
slits (:class:`~pypeit.slittrace.SlitTraceSet`):
Slit edges
spectrograph (:class:`~pypeit.spectrographs.spectrograph.Spectrograph`):
Spectrograph object
The `Spectrograph` instance that sets the instrument used. Used to set
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for polishing these!

Copy link
Collaborator

@kbwestfall kbwestfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Approving now, but we need to run the tests.

@debora-pe
Copy link
Collaborator Author

Tests pass (the failed unit tests are the usual setup_gui tests that my machine have problems with):

--- PYTEST PYPEIT UNIT TESTS PASSED  256 passed, 60 warnings in 363.78s (0:06:03) ---
--- PYTEST UNIT TESTS FAILED  7 failed, 145 passed, 168 warnings in 4220.26s (1:10:20) ---
--- PYTEST VET TESTS PASSED  62 passed, 99 warnings in 5440.19s (1:30:40) ---
--- PYPEIT DEVELOPMENT SUITE PASSED 247/247 TESTS  ---
Testing Started at 2024-10-21T17:38:51.617178
Testing Completed at 2024-10-22T07:48:40.394650
Total Time: 14:09:48.777472

@debora-pe debora-pe merged commit a000b46 into develop Oct 29, 2024
18 checks passed
@debora-pe debora-pe deleted the tilts_fwhm branch October 29, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants