Tox CI fix #1656
Merged
Tox CI fix #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbowers7
reviewed
Aug 18, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #1656 +/- ##
========================================
Coverage 41.03% 41.03%
========================================
Files 189 189
Lines 43221 43221
========================================
Hits 17736 17736
Misses 25485 25485 |
|
squashed the bugs, ready for review... |
kbwestfall
approved these changes
Aug 18, 2023
tbowers7
approved these changes
Aug 18, 2023
|
Thx, @tepickering ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
toxbecame more pedantic about environment names exactly matching what's intox.ini. Previously, one could leave off, say, thepy311-at the beginning of an environment name andtoxwould assume the available python version is 3.11 and carry on. Now it only works if there is an exact match intox list. This PR tweakstox.iniand the CI workflows to use python version format that is consistent and create fully qualifies tox environments in the workflows.