Slitmask matching error #1655
Merged
Slitmask matching error #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debora-pe
approved these changes
Aug 18, 2023
SunilSimha
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a display command used for debugging and throws an error if all of the slit edges are masked after the slit-design matching. This catches an error from one of @SunilSimha's DEIMOS datasets. The solution was to change the
edge_thresh. This improved error message hopefully points users in the right direction, compared to the old obscure one that was completely unrelated.Changes to
slitmask.pyare due to an unrelated OCD moment.