expanded default resln_frac_bounds to accommodate oversampled spectro…

…graphs
pypeit · Aug 18, 2023 · aefd139 · aefd139
1 parent 6f93ac1
commit aefd139
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/pypeit/core/telluric.py b/pypeit/core/telluric.py
@@ -1353,7 +1353,7 @@ def eval_poly_model(theta, obj_dict):
 def sensfunc_telluric(wave, counts, counts_ivar, counts_mask, exptime, airmass, std_dict,
                       telgridfile, teltype, log10_blaze_function=None, ech_orders=None, polyorder=8, ntell=4,
                       mask_hydrogen_lines=True, mask_helium_lines=False, hydrogen_mask_wid=10.,
-                      resln_guess=None, resln_frac_bounds=(0.5, 1.5), pix_shift_bounds=(-5.0, 5.0),
+                      resln_guess=None, resln_frac_bounds=(0.3, 1.5), pix_shift_bounds=(-5.0, 5.0),
                       delta_coeff_bounds=(-20.0, 20.0), minmax_coeff_bounds=(-5.0, 5.0),
                       sn_clip=30.0, ballsize=5e-4, only_orders=None, maxiter=3, lower=3.0,
                       upper=3.0, tol=1e-3, popsize=30, recombination=0.7, polish=True, disp=False,
@@ -2387,7 +2387,7 @@ def empty_model_table(norders, nspec, ntell=4, n_obj_par=0):
 
     def __init__(self, wave, flux, ivar, gpm, telgridfile, teltype, obj_params, init_obj_model,
                  eval_obj_model, log10_blaze_function=None, ech_orders=None, sn_clip=30.0, ntell=4,
-                 airmass_guess=1.5, resln_guess=None, resln_frac_bounds=(0.5, 1.5), pix_shift_bounds=(-5.0, 5.0),
+                 airmass_guess=1.5, resln_guess=None, resln_frac_bounds=(0.3, 1.5), pix_shift_bounds=(-5.0, 5.0),
                  pix_stretch_bounds=(0.9,1.1), maxiter=2, sticky=True, lower=3.0, upper=3.0,
                  seed=777, ballsize = 5e-4, tol=1e-3, diff_evol_maxiter=1000,  popsize=30,
                  recombination=0.7, polish=True, disp=False, sensfunc=False, debug=False):

diff --git a/pypeit/par/pypeitpar.py b/pypeit/par/pypeitpar.py
@@ -2137,12 +2137,12 @@ def __init__(self, telgridfile=None, sn_clip=None, resln_guess=None, resln_frac_
 
 
         pars['resln_frac_bounds'] = tuple_force(pars['resln_frac_bounds'])
-        defaults['resln_frac_bounds'] = (0.5,1.5)
+        defaults['resln_frac_bounds'] = (0.3,1.5)
         dtypes['resln_frac_bounds'] = tuple
         descr['resln_frac_bounds'] = 'Bounds for the resolution fit optimization which is part of the telluric model. ' \
-                                     'This range is in units of the resln_guess, so the (0.5, 1.5) would bound the ' \
+                                     'This range is in units of the resln_guess, so the (0.3, 1.5) would bound the ' \
                                      'spectral resolution fit to be within the range ' \
-                                     'bounds_resln = (0.5*resln_guess, 1.5*resln_guess)'
+                                     'bounds_resln = (0.3*resln_guess, 1.5*resln_guess)'
 
         pars['pix_shift_bounds'] = tuple_force(pars['pix_shift_bounds'])
         defaults['pix_shift_bounds'] = (-5.0,5.0)