Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scattlight #300

Merged
merged 3 commits into from
Nov 26, 2023
Merged

add scattlight #300

merged 3 commits into from
Nov 26, 2023

Conversation

rcooke-ast
Copy link
Collaborator

Pull request associated with this following PR

profxj
profxj approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we (you) add a vet test of some sort to
"insure" quality?

@rcooke-ast
Copy link
Collaborator Author

That's a good idea... I'll stew on it and add it in... possibly for both ESI and KCWI...

@rcooke-ast
Copy link
Collaborator Author

Added 2 vet tests... and passing... merging...
image

@rcooke-ast rcooke-ast merged commit a8b8d2b into develop Nov 26, 2023
@rcooke-ast rcooke-ast deleted the scattlight_model branch November 26, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profxj profxj profxj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcooke-ast @profxj