-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: platform tag detection #560
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
==========================================
+ Coverage 70.07% 72.35% +2.27%
==========================================
Files 13 13
Lines 1076 1085 +9
==========================================
+ Hits 754 785 +31
+ Misses 322 300 -22
☔ View full report in Codecov by Sentry. |
- use `struct.calcsize("P") == 4` rather than `sys.maxsize == 2147483647` - extend the 32bit check to `linux-aarch64` => `linux-armv7l`
4b4ee03
to
d324e41
Compare
Could you add test coverage for the new lines not covered yet (the ones codecov pointed out)? |
I'll try but it's not covered right now so it's not as easy as just extending existing test: |
Done |
Thanks – one more thing: add a descriptive note (and attribution to yourself) to the changelog ( |
struct.calcsize("P") == 4
rather thansys.maxsize == 2147483647
to check for 32bit interpreter(same as stdlib
platform.architecture
default implementation)linux-aarch64
=>linux-armv7l
(fixes AssertionError: would build wheel with unsupported tag ('cp38', 'cp38', 'linux_aarch64') #367)The first one fixes platform tag detection with GraalPy (xref pypa/packaging#710 / pypa/packaging#711)