Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve symbolic links for environment metadata #2686

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jan 22, 2024

Resolves #2682

Caution

DO NOT CHECKOUT THE FIRST COMMIT!
I tried running tox -e py311 and it completely wiped my Python installation. 😢

@gaborbernat gaborbernat marked this pull request as draft January 22, 2024 19:11
@ofek ofek marked this pull request as ready for review January 22, 2024 22:34
@ofek
Copy link
Contributor Author

ofek commented Jan 22, 2024

This is ready for review.

Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests please 😁

@gaborbernat
Copy link
Contributor

@ofek plan to pick it up again, or shall I close it?

@ofek
Copy link
Contributor Author

ofek commented Jan 31, 2024

How do you recommend testing?

@gaborbernat
Copy link
Contributor

A unit test sounds good 👍

@gaborbernat gaborbernat merged commit c221b32 into pypa:main Feb 21, 2024
47 checks passed
@ofek
Copy link
Contributor Author

ofek commented Feb 21, 2024

Oh snap sorry, I forgot to follow-up with the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

venv base-executable path does not resolve symlinks using realpath()
2 participants