-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change activation call to be a list of commands #2424
Conversation
04374e9
to
4f20993
Compare
@gaborbernat Is something like this what you had in mind? |
@gaborbernat Could you please comment whether this approach is what you had in mind when making the activation command a list of strings? Should I continue debugging it to make it work on Windows or is it something else you meant? Reference conversation: #2422 (comment) |
Yeah you are on the right path. |
@kubouch updates on this? |
I didn't have time to investigate the Windows issue because I had to focus on my actual work but I'd like this to be finished. If you have an idea why it's failing on Windows, that would help a lot. |
Not sure sadly. |
59e6ae0
to
143c4cc
Compare
Seems no longer needed. |
OK, so the activation command being a list is no longer necessary? |
Would still be nice to make the change, but seems we can't get it working 👍 |
Yeah, it's something related to the Windows paths but I couldn't locate the issue. |
ActivationTester will use a list of strings as the command instead of just a string.
Required to proceed with #2422
Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)!
tox -e fix_lint
)docs/changelog
folder